[webkit-reviews] review granted: [Bug 179646] Long pressing a phone number with spaces in it results in a link sheet instead of a data detectors sheet : [Attachment 326832] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Nov 13 18:32:28 PST 2017
Darin Adler <darin at apple.com> has granted Tim Horton <thorton at apple.com>'s
request for review:
Bug 179646: Long pressing a phone number with spaces in it results in a link
sheet instead of a data detectors sheet
https://bugs.webkit.org/show_bug.cgi?id=179646
Attachment 326832: Patch
https://bugs.webkit.org/attachment.cgi?id=326832&action=review
--- Comment #3 from Darin Adler <darin at apple.com> ---
Comment on attachment 326832
--> https://bugs.webkit.org/attachment.cgi?id=326832
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=326832&action=review
> Source/WebCore/editing/cocoa/DataDetection.h:65
> + WEBCORE_EXPORT static bool URLCanBePresentedByDataDetectors(const URL&);
I don’t think this function needs the word “URL” in its name. Either
linkCanBePresentefdByDataDetectors or canBePresentedByDataDetectors seems fine
to me.
> Source/WebKit/UIProcess/ios/WKActionSheetAssistant.mm:559
> + NSURL *targetURL = [NSURL
_web_URLWithWTFString:_positionInformation->url];
Why isn’t this just:
NSURL *targetURL = _positionInformation->url;
Does the _web_URLWithWTFString method do something special that the NSURL
operator from WebCore::URL does not?
More information about the webkit-reviews
mailing list