[webkit-reviews] review granted: [Bug 179639] We need to set topCallFrame when calling Wasm::Memory::grow from the JIT : [Attachment 326822] patch

[bugzilla-daemon at webkit.org]

JF Bastien <jfbastien at apple.com> has granted Saam Barati <sbarati at apple.com>'s
request for review:
Bug 179639: We need to set topCallFrame when calling Wasm::Memory::grow from
the JIT
https://bugs.webkit.org/show_bug.cgi?id=179639

Attachment 326822: patch

https://bugs.webkit.org/attachment.cgi?id=326822&action=review




--- Comment #4 from JF Bastien <jfbastien at apple.com> ---
Comment on attachment 326822
  --> https://bugs.webkit.org/attachment.cgi?id=326822
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=326822&action=review

r=me

> Source/JavaScriptCore/wasm/WasmInstance.cpp:56
> +Ref<Instance> Instance::create(Context* context, Ref<Module>&& module,
EntryFrame** topEntryFramePointer, StoreTopCallFrameCallback storeTopCallFrame)

Make it && here too, and WTFMove below.

> Source/JavaScriptCore/wasm/WasmInstance.h:47
> +    static Ref<Instance> create(Context* context, Ref<Module>&& module,
EntryFrame** topEntryFramePointer, StoreTopCallFrameCallback storeTopCallFrame
= nullptr);

&& here too. Why nullptr? Seems nicer to force passing a no-op function when
appropriate, otherwise it's not obvious that you're opting out.

> Source/JavaScriptCore/wasm/WasmInstance.h:110
> +	   if (m_storeTopCallFrame)

I'd make this never nullptr.

> Source/JavaScriptCore/wasm/WasmInstance.h:131
> +    WTF::Function<void(void*)> m_storeTopCallFrame;

StoreTopCallFrameCallback from above.