[webkit-reviews] review canceled: [Bug 178751] Merge NetworkProcess::EnsurePrivateBrowsingSession and NetworkProcess::AddWebsiteDataStore into one message type : [Attachment 326818] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has canceled Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 178751: Merge NetworkProcess::EnsurePrivateBrowsingSession and
NetworkProcess::AddWebsiteDataStore into one message type
https://bugs.webkit.org/show_bug.cgi?id=178751

Attachment 326818: Patch

https://bugs.webkit.org/attachment.cgi?id=326818&action=review




--- Comment #8 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 326818
  --> https://bugs.webkit.org/attachment.cgi?id=326818
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=326818&action=review

> Source/WebKit/NetworkProcess/mac/RemoteNetworkingContext.mm:99
> +    if (!sessionID.isEphemeral()) {
> +	   bool result =
SandboxExtension::consumePermanently(parameters.cookieStoragePathExtensionHandl
e);
> +	   ASSERT_UNUSED(result, result);
> +    }

I reworked this part to only consume sandbox extensions if it's a persistent
session because consuming empty sandbox extensions was succeeding and
asserting.

> Source/WebKit/WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm:62
> +	   bool result =
SandboxExtension::consumePermanently(parameters.cookieStoragePathExtensionHandl
e);

ditto