[webkit-reviews] review denied: [Bug 179631] Web Inspector: refactor active WebSocket tracking to not use raw pointers : [Attachment 326792] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has denied Devin Rousso
<webkit at devinrousso.com>'s request for review:
Bug 179631: Web Inspector: refactor active WebSocket tracking to not use raw
pointers
https://bugs.webkit.org/show_bug.cgi?id=179631

Attachment 326792: Patch

https://bugs.webkit.org/attachment.cgi?id=326792&action=review




--- Comment #4 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 326792
  --> https://bugs.webkit.org/attachment.cgi?id=326792
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=326792&action=review

> Source/WebCore/Modules/websockets/WebSocket.cpp:182
> +HashSet<Ref<WebSocket>>& WebSocket::allActiveWebSockets(const LockHolder&)

WebSockets are added in their constructor and removed in their destructor. 
This will make it so they are added in their constructor and never deleted
because their destructor will never be called because there will always be at
least one ref.