[webkit-reviews] review denied: [Bug 179480] matchRegistration does not need to go to StorageProcess if no service worker is registered : [Attachment 326786] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has denied youenn fablet <youennf at gmail.com>'s
request for review:
Bug 179480: matchRegistration does not need to go to StorageProcess if no
service worker is registered
https://bugs.webkit.org/show_bug.cgi?id=179480

Attachment 326786: Patch

https://bugs.webkit.org/attachment.cgi?id=326786&action=review




--- Comment #16 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 326786
  --> https://bugs.webkit.org/attachment.cgi?id=326786
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=326786&action=review

> Source/WebCore/workers/service/server/SWServer.h:113
> +	   HashMap<String, uint64_t> m_originCounts;

OriginStore was just supposed to be an interface. We want as much of the store
complexity/logic as possible out of SWServer. For this reason, I still believe
the counts should be handled at WebSWOriginStore level. WebSWOriginStore
basically becomes a HashCountedSet, which is fine.

> LayoutTests/imported/w3c/ChangeLog:7
> +

What's the upstream PR for this change? why is this needed? Where is
document.body used? Could not find body being used in activation.https.html, is
it used from an imported script or iframe?