[webkit-reviews] review granted: [Bug 179619] Make the jsc shell loadGetterFromGetterSetter() function more robust. : [Attachment 326776] proposed patch.

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Mark Lam <mark.lam at apple.com>'s
request for review:
Bug 179619: Make the jsc shell loadGetterFromGetterSetter() function more
robust.
https://bugs.webkit.org/show_bug.cgi?id=179619

Attachment 326776: proposed patch.

https://bugs.webkit.org/attachment.cgi?id=326776&action=review




--- Comment #2 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 326776
  --> https://bugs.webkit.org/attachment.cgi?id=326776
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=326776&action=review

> Source/JavaScriptCore/jsc.cpp:3030
> +    if (UNLIKELY(exec->argumentCount() < 1)) {
> +	   throwTypeError(exec, scope, ASCIILiteral("Invalid use of
loadGetterFromGetterSetter test function: missing argument"));
> +	   return encodedJSValue();
> +    }

This is unneeded unless you really care about the error message. This will fall
out of the check below.