[webkit-reviews] review granted: [Bug 174737] CSS properties stroke-width/stroke-color and -webkit-text-stroke-width/-webkit-text-stroke-color should not be mixed : [Attachment 323246] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Per Arne Vollan
<pvollan at apple.com>'s request for review:
Bug 174737: CSS properties stroke-width/stroke-color and
-webkit-text-stroke-width/-webkit-text-stroke-color should not be mixed
https://bugs.webkit.org/show_bug.cgi?id=174737

Attachment 323246: Patch

https://bugs.webkit.org/attachment.cgi?id=323246&action=review




--- Comment #22 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 323246
  --> https://bugs.webkit.org/attachment.cgi?id=323246
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=323246&action=review

Seems reasonable, r=me

> Source/WebCore/rendering/style/RenderStyle.cpp:2358
> -    if (!hasExplicitlySetStrokeWidth())
> +    if (!hasExplicitlySetStrokeColor())
>	   return textStrokeWidth();

This needs a comment. It really reads like a bug.