[webkit-reviews] review granted: [Bug 173793] Move JSONValues to WTF and convert uses of InspectorValues.h to JSONValues.h : [Attachment 326760] Updated patch

[bugzilla-daemon at webkit.org]

Brian Burg <bburg at apple.com> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 173793: Move JSONValues to WTF and convert uses of InspectorValues.h to
JSONValues.h
https://bugs.webkit.org/show_bug.cgi?id=173793

Attachment 326760: Updated patch

https://bugs.webkit.org/attachment.cgi?id=326760&action=review




--- Comment #7 from Brian Burg <bburg at apple.com> ---
Comment on attachment 326760
  --> https://bugs.webkit.org/attachment.cgi?id=326760
Updated patch

View in context: https://bugs.webkit.org/attachment.cgi?id=326760&action=review

r=me

This probably requires changes in Safari / WebInspector.framework code that has
a dependency on this class. I'll land this patch and an internal change at the
same time to avoid problems.

Thanks Carlos for picking this back up!

>
Source/WTF/wtf/JSONValues.cppSource/JavaScriptCore/inspector/InspectorValues.cp
p:47
> +    ObjectBegin,

Nice cleanup. This code is really old, I think we may switch over to use a
shared event based JSON parser in the future.