[webkit-reviews] review granted: [Bug 179598] [Cairo] Move state stack, CTM, transparency layer operations in GraphicsContextCairo to CairoOperations : [Attachment 326721] Patch

[bugzilla-daemon at webkit.org]

Carlos Garcia Campos <cgarcia at igalia.com> has granted Zan Dobersek
<zan at falconsigh.net>'s request for review:
Bug 179598: [Cairo] Move state stack, CTM, transparency layer operations in
GraphicsContextCairo to CairoOperations
https://bugs.webkit.org/show_bug.cgi?id=179598

Attachment 326721: Patch

https://bugs.webkit.org/attachment.cgi?id=326721&action=review




--- Comment #2 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 326721
  --> https://bugs.webkit.org/attachment.cgi?id=326721
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=326721&action=review

> Source/WebCore/platform/graphics/cairo/CairoOperations.cpp:56
> +void save(PlatformContextCairo& platformContext)
> +{
> +    platformContext.save();
> +}
> +
> +void restore(PlatformContextCairo& platformContext)
> +{
> +    platformContext.restore();
> +}

What's the point of these? They don't use cairo directly, I guess caller could
call save restore on platform context, no? Just consistency?

> Source/WebCore/platform/graphics/cairo/CairoOperations.cpp:90
> +    cairo_paint_with_alpha(cr, platformContext.layers().last());
> +    platformContext.layers().removeLast();

We could use takeLast() here.