[webkit-reviews] review granted: [Bug 179576] Avoid composing the message + recipient name for crash logs until a failure actually occurs : [Attachment 326683] Patch

[bugzilla-daemon at webkit.org]

mitz at webkit.org has granted Tim Horton <thorton at apple.com>'s request for
review:
Bug 179576: Avoid composing the message + recipient name for crash logs until a
failure actually occurs
https://bugs.webkit.org/show_bug.cgi?id=179576

Attachment 326683: Patch

https://bugs.webkit.org/attachment.cgi?id=326683&action=review




--- Comment #8 from mitz at webkit.org ---
Comment on attachment 326683
  --> https://bugs.webkit.org/attachment.cgi?id=326683
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=326683&action=review

> Source/WebKit/Platform/IPC/mac/ConnectionMac.mm:250
> +	  
WebKit::setCrashReportApplicationSpecificInformation((CFStringRef)[NSString
stringWithFormat:@"Unhandled error code %x, message '%s::%s'", kr,
message->messageReceiverName().data(), message->messageName().data()]);

The :: makes more sense, but I wonder if the change in format would disturb
some long-running data aggregation. Probably not!