[webkit-reviews] review granted: [Bug 179576] Use StringBuilder instead of NSString to build the full message name for crash logs : [Attachment 326681] Patch

[bugzilla-daemon at webkit.org]

mitz at webkit.org has granted Tim Horton <thorton at apple.com>'s request for
review:
Bug 179576: Use StringBuilder instead of NSString to build the full message
name for crash logs
https://bugs.webkit.org/show_bug.cgi?id=179576

Attachment 326681: Patch

https://bugs.webkit.org/attachment.cgi?id=326681&action=review




--- Comment #3 from mitz at webkit.org ---
Comment on attachment 326681
  --> https://bugs.webkit.org/attachment.cgi?id=326681
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=326681&action=review

> Source/WebKit/Platform/IPC/mac/ConnectionMac.mm:291
> +   
message->setMessageName(messageNameBuilder.toString().createCFString().get());

I wonder why MachMessage’s messageName needs to be a CFString.