[webkit-reviews] review granted: [Bug 179562] We should ensure that operationStrCat2 and operationStrCat3 are never passed Symbols as arguments. : [Attachment 326667] proposed patch.

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Mark Lam <mark.lam at apple.com>'s
request for review:
Bug 179562: We should ensure that operationStrCat2 and operationStrCat3 are
never passed Symbols as arguments.
https://bugs.webkit.org/show_bug.cgi?id=179562

Attachment 326667: proposed patch.

https://bugs.webkit.org/attachment.cgi?id=326667&action=review




--- Comment #2 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 326667
  --> https://bugs.webkit.org/attachment.cgi?id=326667
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=326667&action=review

r=me

> Source/JavaScriptCore/dfg/DFGFixupPhase.cpp:205
> +		       m_insertionSet.insertNode(
> +			   m_indexInBlock, SpecNone, Check, node->origin,
> +			   Edge(edge.node(), NotSymbolUse));

Might be worth a comment saying why we do this.