[webkit-reviews] review granted: [Bug 179519] Rebase some layout tests : [Attachment 326534] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Nov 10 14:05:53 PST 2017


Alex Christensen <achristensen at apple.com> has granted Megan Gardner
<megan_gardner at apple.com>'s request for review:
Bug 179519: Rebase some layout tests
https://bugs.webkit.org/show_bug.cgi?id=179519

Attachment 326534: Patch

https://bugs.webkit.org/attachment.cgi?id=326534&action=review




--- Comment #3 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 326534
  --> https://bugs.webkit.org/attachment.cgi?id=326534
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=326534&action=review

>> LayoutTests/platform/ios-wk2/TestExpectations:1227
>> +editing/selection/3690703-2.html [ Pass ]
> 
> For these, did you check the flakiness dashboard to see if they’ve been
stable on the bots recently?

They're always failing.  The rebasing will make them either always pass or
become flaky.  You might want to land the rebasing, wait a weekend, then mark
the non-flaky ones as passing.


More information about the webkit-reviews mailing list