[webkit-reviews] review granted: [Bug 179535] [Web Animations] Implement getAnimations() : [Attachment 326624] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Nov 10 14:00:36 PST 2017


Simon Fraser (smfr) <simon.fraser at apple.com> has granted Antoine Quint
<graouts at apple.com>'s request for review:
Bug 179535: [Web Animations] Implement getAnimations()
https://bugs.webkit.org/show_bug.cgi?id=179535

Attachment 326624: Patch

https://bugs.webkit.org/attachment.cgi?id=326624&action=review




--- Comment #6 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 326624
  --> https://bugs.webkit.org/attachment.cgi?id=326624
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=326624&action=review

> Source/WebCore/animation/AnimationEffect.h:45
> +    void setAnimation(WebAnimation* animation) { m_animation = animation; }

I think the current hotness here is to pass a RefPtr<WebAnimation>&& so the
caller can WTFMove if they are passing ownership.


More information about the webkit-reviews mailing list