[webkit-reviews] review canceled: [Bug 179513] Web Inspector: Include a NetworkAgent in ServiceWorkers for network debugging : [Attachment 326610] [PATCH] Proposed Fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Nov 10 13:03:09 PST 2017


Joseph Pecoraro <joepeck at webkit.org> has canceled Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 179513: Web Inspector: Include a NetworkAgent in ServiceWorkers for network
debugging
https://bugs.webkit.org/show_bug.cgi?id=179513

Attachment 326610: [PATCH] Proposed Fix

https://bugs.webkit.org/attachment.cgi?id=326610&action=review




--- Comment #17 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 326610
  --> https://bugs.webkit.org/attachment.cgi?id=326610
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=326610&action=review

> Source/WebCore/inspector/agents/InspectorNetworkAgent.cpp:832
>	   if (IdentifiersFactory::requestId(channel->identifier()) !=
requestId)

Oops this should be `==` now to fix the test.


More information about the webkit-reviews mailing list