[webkit-reviews] review granted: [Bug 179503] Make CachedResource::redirectReceived asynchronous : [Attachment 326479] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 179503: Make CachedResource::redirectReceived asynchronous
https://bugs.webkit.org/show_bug.cgi?id=179503

Attachment 326479: Patch

https://bugs.webkit.org/attachment.cgi?id=326479&action=review




--- Comment #3 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 326479
  --> https://bugs.webkit.org/attachment.cgi?id=326479
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=326479&action=review

> Source/WebCore/loader/SubresourceLoader.cpp:186
> +    auto callSuper = [this, protectedThis = makeRef(*this),
redirectResponse] (CompletionHandler<void(ResourceRequest&&)>&&
completionHandler, ResourceRequest&& newRequest) mutable {

"callSuper" is not a great name. Can you name this with something that
describes what it is actually trying to accomplish?

> Source/WebCore/loader/cache/CachedRawResource.cpp:119
> +static void iterate(CachedResourceHandle<CachedRawResource>&& handle,
CachedRawResourceClient& client, Vector<std::pair<ResourceRequest,
ResourceResponse>>&& redirectsInReverseOrder,
CompletionHandler<void(ResourceRequest&&)>&& completionHandler)

iterate over what?