[webkit-reviews] review granted: [Bug 179460] Remove TEC decoders that duplicate ICU decoders : [Attachment 326548] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Maciej Stachowiak <mjs at apple.com>'s
request for review:
Bug 179460: Remove TEC decoders that duplicate ICU decoders
https://bugs.webkit.org/show_bug.cgi?id=179460

Attachment 326548: Patch

https://bugs.webkit.org/attachment.cgi?id=326548&action=review




--- Comment #4 from Darin Adler <darin at apple.com> ---
Comment on attachment 326548
  --> https://bugs.webkit.org/attachment.cgi?id=326548
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=326548&action=review

Fewer encodings in this category than I expected, but I understand that this is
just one step on the path.

> Source/WebCore/platform/text/TextEncodingRegistry.cpp:125
> +    ASSERT_WITH_MESSAGE(!oldAtomicName, "Duplicate text encoding name %s for
%s (previously registered as %s)", alias, atomicName, oldAtomicName);

Technically, making this an assertion requires changing the #if above to
ASSERT_DISABLED rather than ERROR_DISABLED. Makes me think our Assertions.h
macros are a bit too complex.