[webkit-reviews] review granted: [Bug 179522] check-webkit-style: AttributeError: 'NoneType' object has no attribute 'major' : [Attachment 326558] Patch

[bugzilla-daemon at webkit.org]

Aakash Jain <aakash_jain at apple.com> has granted Fujii Hironori
<Hironori.Fujii at sony.com>'s request for review:
Bug 179522: check-webkit-style: AttributeError: 'NoneType' object has no
attribute 'major'
https://bugs.webkit.org/show_bug.cgi?id=179522

Attachment 326558: Patch

https://bugs.webkit.org/attachment.cgi?id=326558&action=review




--- Comment #3 from Aakash Jain <aakash_jain at apple.com> ---
Comment on attachment 326558
  --> https://bugs.webkit.org/attachment.cgi?id=326558
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=326558&action=review

> Tools/Scripts/webkitpy/port/ios_simulator.py:118
> +	   return
Version(self.host.platform.xcode_sdk_version('iphonesimulator'))

This might pass None to Version(). We should have a log statement at
https://trac.webkit.org/browser/webkit/trunk/Tools/Scripts/webkitpy/common/vers
ion.py#L44

That can be done either in this patch or separate patch.