[webkit-reviews] review granted: [Bug 178390] Support recursive tail call optimization for polymorphic calls : [Attachment 324413] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Nov 10 08:40:02 PST 2017


Saam Barati <sbarati at apple.com> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 178390: Support recursive tail call optimization for polymorphic calls
https://bugs.webkit.org/show_bug.cgi?id=178390

Attachment 324413: Patch

https://bugs.webkit.org/attachment.cgi?id=324413&action=review




--- Comment #15 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 324413
  --> https://bugs.webkit.org/attachment.cgi?id=324413
Patch

r=me
It’d be nice to both add this with tests and micro benchmarks. An interesting
test would be having all of the polymorphic calllees on the in-line stack, so
you jump to different places depending on callee. It’d also be interesting to
have tests where one of the polymorphic callees is on the stack, and we go down
normal in lining for the others.


More information about the webkit-reviews mailing list