[webkit-reviews] review granted: [Bug 179520] [webkitpy] Fix PlatformInfo._win_version since r224657 : [Attachment 326560] Patch

[bugzilla-daemon at webkit.org]

Aakash Jain <aakash_jain at apple.com> has granted Fujii Hironori
<Hironori.Fujii at sony.com>'s request for review:
Bug 179520: [webkitpy] Fix PlatformInfo._win_version since r224657
https://bugs.webkit.org/show_bug.cgi?id=179520

Attachment 326560: Patch

https://bugs.webkit.org/attachment.cgi?id=326560&action=review




--- Comment #4 from Aakash Jain <aakash_jain at apple.com> ---
Comment on attachment 326560
  --> https://bugs.webkit.org/attachment.cgi?id=326560
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=326560&action=review

> Tools/Scripts/webkitpy/common/system/platforminfo.py:199
> +    def _win_version_tuple_from_cmd(self):

This doesn't return tuple anymore, we should rename it to
_win_version_from_cmd.