[webkit-reviews] review granted: [Bug 179528] The memory consumption of DFG::BasicBlock can be easily reduced a bit : [Attachment 326581] Patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Robin Morisset
<rmorisset at apple.com>'s request for review:
Bug 179528: The memory consumption of DFG::BasicBlock can be easily reduced a
bit
https://bugs.webkit.org/show_bug.cgi?id=179528

Attachment 326581: Patch

https://bugs.webkit.org/attachment.cgi?id=326581&action=review




--- Comment #3 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 326581
  --> https://bugs.webkit.org/attachment.cgi?id=326581
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=326581&action=review

r=me

> Source/JavaScriptCore/bytecode/Operands.h:186
>      {

You can just write this as:
operand(operand) = value

> Source/JavaScriptCore/bytecode/Operands.h:252
> +    size_t m_numArguments;

I say make this unsigned. This probably won’t matter because of padding, but it
might be useful if someone adds a field in the future.