[webkit-reviews] review granted: [Bug 179508] [WinCairo] Cannot find ImageDiff executable : [Attachment 326495] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Nov 9 15:56:59 PST 2017


Per Arne Vollan <pvollan at apple.com> has granted Basuke Suzuki
<Basuke.Suzuki at sony.com>'s request for review:
Bug 179508: [WinCairo] Cannot find ImageDiff executable
https://bugs.webkit.org/show_bug.cgi?id=179508

Attachment 326495: patch

https://bugs.webkit.org/attachment.cgi?id=326495&action=review




--- Comment #2 from Per Arne Vollan <pvollan at apple.com> ---
Comment on attachment 326495
  --> https://bugs.webkit.org/attachment.cgi?id=326495
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=326495&action=review

R=me.

> Tools/Scripts/webkitpy/port/win.py:165
> +	   """Return current platform is Cygwin or not"""

Perhaps change this to "Return whether current platform is Cygwin or not".


More information about the webkit-reviews mailing list