[webkit-reviews] review granted: [Bug 179283] Web Inspector: support undo/redo of insertAdjacentHTML : [Attachment 326439] Patch

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Devin Rousso
<webkit at devinrousso.com>'s request for review:
Bug 179283: Web Inspector: support undo/redo of insertAdjacentHTML
https://bugs.webkit.org/show_bug.cgi?id=179283

Attachment 326439: Patch

https://bugs.webkit.org/attachment.cgi?id=326439&action=review




--- Comment #4 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 326439
  --> https://bugs.webkit.org/attachment.cgi?id=326439
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=326439&action=review

r=me

> Source/WebCore/dom/Element.h:315
> +    ExceptionOr<void> insertAdjacentHTML(const String& where, const String&
html, std::optional<NodeVector&> nodes);

I think the name `nodes` could be `addedNodes` and it would be clearer.