[webkit-reviews] review granted: [Bug 179483] [LayoutState cleanup] Remove renderer data members from state maintainers. : [Attachment 326452] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted zalan <zalan at apple.com>'s request for
review:
Bug 179483: [LayoutState cleanup] Remove renderer data members from state
maintainers.
https://bugs.webkit.org/show_bug.cgi?id=179483

Attachment 326452: Patch

https://bugs.webkit.org/attachment.cgi?id=326452&action=review




--- Comment #3 from Darin Adler <darin at apple.com> ---
Comment on attachment 326452
  --> https://bugs.webkit.org/attachment.cgi?id=326452
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=326452&action=review

> Source/WebCore/rendering/LayoutState.h:165
> +    LayoutContext* m_layoutContext { nullptr };

I would have just called this "m_acontext" since the class is all about layout
and has layout in its name.

> Source/WebCore/rendering/LayoutState.h:185
> +    LayoutContext& m_layoutContext;

Ditto.