[webkit-reviews] review requested: [Bug 175172] Use enum classes within FileSystem : [Attachment 326406] Patch - Additional Cleanup

[bugzilla-daemon at webkit.org]

Christopher Reid <christopher.reid at am.sony.com> has asked  for review:
Bug 175172: Use enum classes within FileSystem
https://bugs.webkit.org/show_bug.cgi?id=175172

Attachment 326406: Patch - Additional Cleanup

https://bugs.webkit.org/attachment.cgi?id=326406&action=review




--- Comment #12 from Christopher Reid <christopher.reid at am.sony.com> ---
Created attachment 326406

  --> https://bugs.webkit.org/attachment.cgi?id=326406&action=review

Patch - Additional Cleanup

Thanks for the feedback Darin. Here's a patch addressing your suggestions.

> But an enum class is not a good fit for masks that need to be or-ed together.
In modern WebKit code this should be an OptionSet instead.

Ah, I didn't realize WebKit had that. I have updated uses of the FileLockMode
enum class to use an OptionSet instead.