[webkit-reviews] review granted: [Bug 179453] Add Windows powershell EWS script : [Attachment 326399] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted Don Olmstead
<don.olmstead at sony.com>'s request for review:
Bug 179453: Add Windows powershell EWS script
https://bugs.webkit.org/show_bug.cgi?id=179453

Attachment 326399: Patch

https://bugs.webkit.org/attachment.cgi?id=326399&action=review




--- Comment #2 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 326399
  --> https://bugs.webkit.org/attachment.cgi?id=326399
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=326399&action=review

I think this looks fine as a new direction, especially since it doesn't affect
or existing tooling at all. I had a couple of minor questions about paths that
I'd like you to confirm before landing.

> Tools/EWSTools/Start-Queue.ps1:47
> +    git clean -f; # Remove any left-over layout test results, added files,
etc.

Does Powershell know where to find 'git'? Or do we need to make sure it's now
part of the user's path? Can this script complain if 'git' is not in the path?

> Tools/EWSTools/Start-Queue.ps1:88
> +    python /Tools/BuildSlaveSupport/kill-old-processes

Ditto my 'git' comments about 'perl' and 'python'. Is Powershell smart enough
to find them if you installed ActiveState stuff, or do we need to document for
the user that they should add relevant paths to the system environment?