[webkit-reviews] review granted: [Bug 179408] [LayoutState cleanup] LayoutContext should own the stack of LayoutState objects : [Attachment 326364] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted zalan <zalan at apple.com>'s request
for review:
Bug 179408: [LayoutState cleanup] LayoutContext should own the stack of
LayoutState objects
https://bugs.webkit.org/show_bug.cgi?id=179408

Attachment 326364: Patch

https://bugs.webkit.org/attachment.cgi?id=326364&action=review




--- Comment #3 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 326364
  --> https://bugs.webkit.org/attachment.cgi?id=326364
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=326364&action=review

> Source/WebCore/rendering/LayoutState.cpp:130
> +void LayoutState::computePaginationInformation(const
LayoutContext::LayoutStateStack& layoutStateStack, RenderBox& renderer,
LayoutUnit pageLogicalHeight, bool pageLogicalHeightChanged)

Please move this function out of the LayoutState at some point.