[webkit-reviews] review granted: [Bug 179276] Web Inspector: Show Internal properties of PaymentRequest in Web Inspector Console : [Attachment 326021] [PATCH] Proposed Fix

[bugzilla-daemon at webkit.org]

Andy Estes <aestes at apple.com> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 179276: Web Inspector: Show Internal properties of PaymentRequest in Web
Inspector Console
https://bugs.webkit.org/show_bug.cgi?id=179276

Attachment 326021: [PATCH] Proposed Fix

https://bugs.webkit.org/attachment.cgi?id=326021&action=review




--- Comment #17 from Andy Estes <aestes at apple.com> ---
Comment on attachment 326021
  --> https://bugs.webkit.org/attachment.cgi?id=326021
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=326021&action=review

It would be nice if the bindings generator could generate all the code you
added to WebInjectedScriptHost. Patch looks good otherwise.

> LayoutTests/resources/ui-helper.js:163
> +    static withUserGesture(callback)
> +    {
> +	   internals.withUserGesture(callback);
> +    }

I'm not sure why we need a wrapper function in ui-helper.js when we could just
call the internals method directly.