[webkit-reviews] review granted: [Bug 179331] [Win] Add WebKitQuartzCoreAdditions library. : [Attachment 326162] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted Per Arne Vollan
<pvollan at apple.com>'s request for review:
Bug 179331: [Win] Add WebKitQuartzCoreAdditions library.
https://bugs.webkit.org/show_bug.cgi?id=179331

Attachment 326162: Patch

https://bugs.webkit.org/attachment.cgi?id=326162&action=review




--- Comment #3 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 326162
  --> https://bugs.webkit.org/attachment.cgi?id=326162
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=326162&action=review

> Source/WebKitLegacy/win/WebKitQuartzCoreAdditions/CMakeLists.txt:52
> +if (${CMAKE_GENERATOR} MATCHES "Ninja")

This check doesn’t seem to do anything different.

> Source/WebKitLegacy/win/WebKitQuartzCoreAdditions/CMakeLists.txt:66
> +add_library(WebKitQuartzCoreAdditions SHARED
${WebKitQuartzCoreAdditions_SOURCES})

Is it a dll?