[webkit-reviews] review granted: [Bug 178168] [JSC] Retry module fetching if previous request fails : [Attachment 324219] Patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Yusuke Suzuki
<utatane.tea at gmail.com>'s request for review:
Bug 178168: [JSC] Retry module fetching if previous request fails
https://bugs.webkit.org/show_bug.cgi?id=178168

Attachment 324219: Patch

https://bugs.webkit.org/attachment.cgi?id=324219&action=review




--- Comment #3 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 324219
  --> https://bugs.webkit.org/attachment.cgi?id=324219
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=324219&action=review

r=me

> Source/JavaScriptCore/builtins/ModuleLoaderPrototype.js:220
> +function requestSatisfy(entry, parameters, fetcher, visited)

Should we just use a default parameter value for visited instead of providing
new @Set at a few call sites?