[webkit-reviews] review granted: [Bug 179247] [JSC][JIT] Clean up SlowPathCall stubs : [Attachment 325916] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 8 10:49:12 PST 2017


Saam Barati <sbarati at apple.com> has granted Yusuke Suzuki
<utatane.tea at gmail.com>'s request for review:
Bug 179247: [JSC][JIT] Clean up SlowPathCall stubs
https://bugs.webkit.org/show_bug.cgi?id=179247

Attachment 325916: Patch

https://bugs.webkit.org/attachment.cgi?id=325916&action=review




--- Comment #2 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 325916
  --> https://bugs.webkit.org/attachment.cgi?id=325916
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=325916&action=review

nice cleanup. r=me

> Source/JavaScriptCore/runtime/CommonSlowPaths.cpp:283
> +SLOW_PATH_DECL(slow_path_check_tdz)
> +{
> +    BEGIN();
> +    THROW(createTDZError(exec));
> +}

Not a fan of this name, this used to be called throw_tdz_error or whatever,
which I think is more intuitive.


More information about the webkit-reviews mailing list