[webkit-reviews] review denied: [Bug 179427] Gigacage.cpp:44:46: warning: ‘*’ in boolean context, suggest ‘&&’ instead [-Wint-in-bool-context] : [Attachment 326333] Patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has denied Michael Catanzaro
<mcatanzaro at igalia.com>'s request for review:
Bug 179427: Gigacage.cpp:44:46: warning: ‘*’ in boolean context, suggest ‘&&’
instead [-Wint-in-bool-context]
https://bugs.webkit.org/show_bug.cgi?id=179427

Attachment 326333: Patch

https://bugs.webkit.org/attachment.cgi?id=326333&action=review




--- Comment #3 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 326333
  --> https://bugs.webkit.org/attachment.cgi?id=326333
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=326333&action=review

> Source/bmalloc/bmalloc/Gigacage.cpp:159
> +#if !BCPU(ARM64)

Not a fan of this. Can we just make it
if (GIGACAGE_RUNWAY > 0)?