[webkit-reviews] review granted: [Bug 179309] iOS supports some text encodings supposedly due to lack of TEC that aren't supported by the TEC decoder on macOS : [Attachment 326314] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 8 09:02:39 PST 2017


Darin Adler <darin at apple.com> has granted Maciej Stachowiak <mjs at apple.com>'s
request for review:
Bug 179309: iOS supports some text encodings supposedly due to lack of TEC that
aren't supported by the TEC decoder on macOS
https://bugs.webkit.org/show_bug.cgi?id=179309

Attachment 326314: Patch

https://bugs.webkit.org/attachment.cgi?id=326314&action=review




--- Comment #8 from Darin Adler <darin at apple.com> ---
Comment on attachment 326314
  --> https://bugs.webkit.org/attachment.cgi?id=326314
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=326314&action=review

> Source/WebCore/platform/text/TextCodecICU.cpp:173
> +    // FIXME: this may not be needed any more.

Should should mention bug 179416, capitalize "this".

> Source/WebCore/platform/text/TextCodecICU.cpp:219
> +    // FIXME: this may not be needed any more.

Ditto.


More information about the webkit-reviews mailing list