[webkit-reviews] review denied: [Bug 179373] [GStreamer] Builds fails with ENABLE_VIDEO=OFF due to GStreamer usage : [Attachment 326326] Patch

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at igalia.com> has denied Adrian Perez
<aperez at igalia.com>'s request for review:
Bug 179373: [GStreamer] Builds fails with ENABLE_VIDEO=OFF due to GStreamer
usage
https://bugs.webkit.org/show_bug.cgi?id=179373

Attachment 326326: Patch

https://bugs.webkit.org/attachment.cgi?id=326326&action=review




--- Comment #8 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 326326
  --> https://bugs.webkit.org/attachment.cgi?id=326326
Patch

OK, wow. That is a surprise to me.

I'm OK with this, assuming multimedia team agrees. (Please find a multimedia
team reviewer.) But if we do it, we need to update existing code that assumes
ENABLE_WEB_AUDIO does not depend on ENABLE_VIDEO. For example, in
GStreamerChecks.cmake, the entire file is guarded by if (ENABLE_VIDEO OR
ENABLE_WEB_AUDIO). That doesn't make sense after this commit, since
ENABLE_VIDEO now implies ENABLE_WEB_AUDIO, the ENABLE_WEB_AUDIO check should be
dropped. I grepped the codebase for 'ENABLE(VIDEO) || ENABLE(WEB_AUDIO)' and
found hits in PlatformMediaSession.cpp and PlatformMediaSessionManager.cpp that
will need to be removed.