[webkit-reviews] review granted: [Bug 179406] Disable implicit animations when adding or removing text track representation layers. : [Attachment 326291] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 7 21:59:04 PST 2017


Simon Fraser (smfr) <simon.fraser at apple.com> has granted Jeremy Jones
<jeremyj-wk at apple.com>'s request for review:
Bug 179406: Disable implicit animations when adding or removing text track
representation layers.
https://bugs.webkit.org/show_bug.cgi?id=179406

Attachment 326291: Patch

https://bugs.webkit.org/attachment.cgi?id=326291&action=review




--- Comment #3 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 326291
  --> https://bugs.webkit.org/attachment.cgi?id=326291
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=326291&action=review

>
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundati
onObjC.mm:1238
> +    [CATransaction begin];
> +    [CATransaction setDisableActions:YES];

Maybe we should make a stack-based class that does this.


More information about the webkit-reviews mailing list