[webkit-reviews] review granted: [Bug 179359] Web Inspector: Add some fast returns in cases where we only call through to a NetworkAgent : [Attachment 326184] [PATCH] Proposed Fix

[bugzilla-daemon at webkit.org]

Devin Rousso <webkit at devinrousso.com> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 179359: Web Inspector: Add some fast returns in cases where we only call
through to a NetworkAgent
https://bugs.webkit.org/show_bug.cgi?id=179359

Attachment 326184: [PATCH] Proposed Fix

https://bugs.webkit.org/attachment.cgi?id=326184&action=review




--- Comment #2 from Devin Rousso <webkit at devinrousso.com> ---
Comment on attachment 326184
  --> https://bugs.webkit.org/attachment.cgi?id=326184
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=326184&action=review

r=me.

Should you also add this to these instrumentation points as well?
 - didReceiveThreadableLoaderResponse
 - didReceiveData

It seems like the logic we had could've theoretically supported saving network
information when there was no frontend, but it would've required some changes
to InspectorNetworkAgent::enable.  Is the main reason that we don't want to do
this performance, or am I missing something?

> Source/WebCore/ChangeLog:14
> +	  
(WebCore::InspectorInstrumentation::continueAfterXFrameOptionsDenied):
> +	   (WebCore::InspectorInstrumentation::continueWithPolicyDownload):

These are not actually modified.  Should they be?  They call into
InspectorInstrumentation::didReceiveResourceResponseImpl, which does call to
InspectorConsoleAgent.	I am unfamiliar with how that agent functions, so I
can't say as to whether it relies on data from before a frontend exists or not.