[webkit-reviews] review granted: [Bug 179343] WebAssembly: improve stack trace : [Attachment 326157] patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted JF Bastien <jfbastien at apple.com>'s
request for review:
Bug 179343: WebAssembly: improve stack trace
https://bugs.webkit.org/show_bug.cgi?id=179343

Attachment 326157: patch

https://bugs.webkit.org/attachment.cgi?id=326157&action=review




--- Comment #4 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 326157
  --> https://bugs.webkit.org/attachment.cgi?id=326157
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=326157&action=review

r=me

> Source/JavaScriptCore/wasm/WasmModuleInformation.cpp:47
> +    , hash(sha1(source))

should we do this lazily?

> Source/JavaScriptCore/wasm/WasmNameSection.h:40
> +	   for (size_t i = 0; i != hash.length(); ++i)

nit: we usually use < instead of != here

> Source/JavaScriptCore/wasm/WasmNameSection.h:43
> +    NameSection() = delete;

Isn't this implicit in you defining the above constructor?

> Source/JavaScriptCore/wasm/WasmNameSection.h:44
> +    NameSection(const NameSection&) = delete;

WTF_MAKE_NONCOPYABLE?