[webkit-reviews] review granted: [Bug 179339] [CG] Adopt CGContextDrawPathDirect() : [Attachment 326155] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Said Abou-Hallawa
<sabouhallawa at apple.com>'s request for review:
Bug 179339: [CG] Adopt CGContextDrawPathDirect()
https://bugs.webkit.org/show_bug.cgi?id=179339

Attachment 326155: Patch

https://bugs.webkit.org/attachment.cgi?id=326155&action=review




--- Comment #3 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 326155
  --> https://bugs.webkit.org/attachment.cgi?id=326155
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=326155&action=review

> Source/WebCore/ChangeLog:19
> +	   shadow because we add the CGPatn to the layerContext and at the end
we

CGPatn?

> Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp:645
> -    CGContextBeginPath(context);
> -    CGContextAddPath(context, path.platformPath());
> -
>      if (state.fillPattern)
>	   applyFillPattern();
>      if (state.strokePattern)
>	   applyStrokePattern();

Is it OK for the add path to happen after applying the fill and stroke
patterns?

> Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp:649
> +#if (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101200) ||
(PLATFORM(IOS) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 100000)

Let's put a #define USE_DRAW_PATH_DIRECT ((PLATFORM(MAC) &&
__MAC_OS_X_VERSION_MIN_REQUIRED >= 101200) || (PLATFORM(IOS) &&
__IPHONE_OS_VERSION_MIN_REQUIRED >= 100000)) at the top of the file and use
that.

> Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp:711
> -    CGContextBeginPath(context);
> -    CGContextAddPath(context, path.platformPath());
> -
>      if (m_state.fillPattern)
>	   applyFillPattern();

Ditto.