[webkit-reviews] review granted: [Bug 179328] Web Inspector: no way to navigate from Resource tree element to its entry in Network Tab : [Attachment 326147] [PATCH] Proposed Fix
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Nov 6 12:23:47 PST 2017
Brian Burg <bburg at apple.com> has granted Joseph Pecoraro <joepeck at webkit.org>'s
request for review:
Bug 179328: Web Inspector: no way to navigate from Resource tree element to its
entry in Network Tab
https://bugs.webkit.org/show_bug.cgi?id=179328
Attachment 326147: [PATCH] Proposed Fix
https://bugs.webkit.org/attachment.cgi?id=326147&action=review
--- Comment #6 from Brian Burg <bburg at apple.com> ---
Comment on attachment 326147
--> https://bugs.webkit.org/attachment.cgi?id=326147
[PATCH] Proposed Fix
View in context: https://bugs.webkit.org/attachment.cgi?id=326147&action=review
r=me
> Source/WebInspectorUI/ChangeLog:29
> + Make use of new ContentMenu utility to add menu items for a URL.
Nit: ContextMenu
> Source/WebInspectorUI/UserInterface/Views/ContextMenuUtilities.js:98
> + contextMenu.appendItem(WI.UIString("Open in New Tab"), () => {
I always find this UIString confusing, because it doesn't explicitly say
Browser Tab. And then I do it and nothing appears in Web Inspector tab. When
windowed, it looks like it's just broken.
More information about the webkit-reviews
mailing list