[webkit-reviews] review granted: [Bug 179322] ScriptExecutionContext::serviceWorkerContainer() should avoid constructing a Navigator object : [Attachment 326125] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 6 11:25:38 PST 2017


Sam Weinig <sam at webkit.org> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 179322: ScriptExecutionContext::serviceWorkerContainer() should avoid
constructing a Navigator object
https://bugs.webkit.org/show_bug.cgi?id=179322

Attachment 326125: Patch

https://bugs.webkit.org/attachment.cgi?id=326125&action=review




--- Comment #3 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 326125
  --> https://bugs.webkit.org/attachment.cgi?id=326125
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=326125&action=review

> Source/WebCore/page/DOMWindow.h:140
>      Navigator* navigator() const;
> +    Navigator* optionalNavigator() const { return m_navigator.get(); }

Should/can navigator() return something non-null?


More information about the webkit-reviews mailing list