[webkit-reviews] review granted: [Bug 179118] [Experiment] Implement code to detect high frequency painting : [Attachment 326128] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Dave Hyatt
<hyatt at apple.com>'s request for review:
Bug 179118: [Experiment] Implement code to detect high frequency painting
https://bugs.webkit.org/show_bug.cgi?id=179118

Attachment 326128: Patch

https://bugs.webkit.org/attachment.cgi?id=326128&action=review




--- Comment #24 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 326128
  --> https://bugs.webkit.org/attachment.cgi?id=326128
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=326128&action=review

> Source/WebCore/rendering/PaintInfo.h:105
> +    const RenderLayer* enclosingSelfPaintingLayer() { return
m_enclosingSelfPaintingLayer; }

I meant the function should be const

> Source/WebCore/rendering/RenderLayer.cpp:176
> +    else if (m_totalPaints && ((now - m_firstPaintTime) / m_totalPaints) >
paintFrequencyTimePerFrameThreshold) {

no else after return.