[webkit-reviews] review granted: [Bug 179321] ServiceWorkerContainer should take a PendingActivity while a service worker job is pending : [Attachment 326123] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 179321: ServiceWorkerContainer should take a PendingActivity while a
service worker job is pending
https://bugs.webkit.org/show_bug.cgi?id=179321

Attachment 326123: Patch

https://bugs.webkit.org/attachment.cgi?id=326123&action=review




--- Comment #2 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 326123
  --> https://bugs.webkit.org/attachment.cgi?id=326123
Patch

The usual style would probably be to have scheduleJob take a completion handler
so that we can ensure to have setpending/unsetpending close one to the other or
use makePendingActivity.
Given m_jobMap is only used to add/remove jobs, it could probably be moved at a
different level as well.