[webkit-reviews] review granted: [Bug 179223] Web Inspector: Selecting a DOM Search Result in Search Tab unexpectedly changes Tabs : [Attachment 325832] [PATCH] Proposed Fix

[bugzilla-daemon at webkit.org]

Devin Rousso <webkit at devinrousso.com> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 179223: Web Inspector: Selecting a DOM Search Result in Search Tab
unexpectedly changes Tabs
https://bugs.webkit.org/show_bug.cgi?id=179223

Attachment 325832: [PATCH] Proposed Fix

https://bugs.webkit.org/attachment.cgi?id=325832&action=review




--- Comment #7 from Devin Rousso <webkit at devinrousso.com> ---
Comment on attachment 325832
  --> https://bugs.webkit.org/attachment.cgi?id=325832
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=325832&action=review

r=me

> Source/WebInspectorUI/ChangeLog:19
> +	   (WI.SearchTabContentView):
> +	   Check experimental setting for experimental sidebars.

This is unrelated.  Did you forget to upload part of the diff, or is this from
another patch?

> Source/WebInspectorUI/UserInterface/Views/ContentBrowser.js:236
> +	   let currentContentView = this.currentContentView;
> +	  
this._updateContentViewSelectionPathNavigationItem(currentContentView);
> +	   this._updateHierarchicalPathNavigationItem(currentContentView ?
currentContentView.representedObject : null);

I would personally restructure this to make use of existing functions.

   
this._updateContentViewSelectionPathNavigationItem(this.currentContentView);
    this.updateHierarchicalPathForCurrentContentView();