[webkit-reviews] review granted: [Bug 179072] Web Inspector: Canvas Tab: selecting Frame tree element should update preview/slider, does nothing : [Attachment 325869] Patch

[bugzilla-daemon at webkit.org]

Matt Baker <mattbaker at apple.com> has granted Devin Rousso
<webkit at devinrousso.com>'s request for review:
Bug 179072: Web Inspector: Canvas Tab: selecting Frame tree element should
update preview/slider, does nothing
https://bugs.webkit.org/show_bug.cgi?id=179072

Attachment 325869: Patch

https://bugs.webkit.org/attachment.cgi?id=325869&action=review




--- Comment #4 from Matt Baker <mattbaker at apple.com> ---
Comment on attachment 325869
  --> https://bugs.webkit.org/attachment.cgi?id=325869
Patch

r=me, with some thoughts:

I left this behavior out during the redesign, because of the effect it has on
the slider when selecting actions in the sidebar with up/down keys. Doing
nothing when selecting a frame tree element probably wasn't the right choice,
but was done to prevent this:

With multiple frames expanded, select the first frame:

Frame 1*
  Action 1
  Action 2
Frame 2
  Action 3

=> Slider shows 2 of 3

Press down arrow once:

Frame 1
  Action 1*
  Action 2
Frame 2
  Action 3

=> Slider shows 1 of 3

For the change in the slider to be monotonic, selecting a frame tree element
would need to select the first child action instead of the last. But this
prevents skipping to the end of the recording by selecting the last frame tree
element.