[webkit-reviews] review granted: [Bug 179236] [Web Animations] Schedule animations registered on the document timeline : [Attachment 326067] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Antoine Quint <graouts at apple.com>'s
request for review:
Bug 179236: [Web Animations] Schedule animations registered on the document
timeline
https://bugs.webkit.org/show_bug.cgi?id=179236

Attachment 326067: Patch

https://bugs.webkit.org/attachment.cgi?id=326067&action=review




--- Comment #24 from Dean Jackson <dino at apple.com> ---
Comment on attachment 326067
  --> https://bugs.webkit.org/attachment.cgi?id=326067
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=326067&action=review

> Source/WebCore/animation/DocumentTimeline.cpp:141
> +    // whihc will be addressed by the refactor tracked by
webkit.org/b/179293.

typo which

> Source/WebCore/animation/DocumentTimeline.cpp:163
> +void DocumentTimeline::windowScreenDidChange(PlatformDisplayID displayID)
> +{
> +#if USE(REQUEST_ANIMATION_FRAME_DISPLAY_MONITOR)

You could leave out this function completely if !USE(RAF_D_M)

> Source/WebCore/animation/DocumentTimeline.h:65
> +    Document* m_document;

Why does this need to be a pointer? You get a Document& in the constructor.
Maybe have this as a Ref<Document> in both places.