[webkit-reviews] review granted: [Bug 179279] [LayoutState cleanup] Move offset/cliprect/pagination code to dedicate methods : [Attachment 326006] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted zalan <zalan at apple.com>'s request
for review:
Bug 179279: [LayoutState cleanup] Move offset/cliprect/pagination code to
dedicate methods
https://bugs.webkit.org/show_bug.cgi?id=179279

Attachment 326006: Patch

https://bugs.webkit.org/attachment.cgi?id=326006&action=review




--- Comment #3 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 326006
  --> https://bugs.webkit.org/attachment.cgi?id=326006
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=326006&action=review

> Source/WebCore/rendering/LayoutState.h:86
> +    void computeOffsets(RenderBox&, LayoutSize offset);
> +    void computeClipRect(RenderBox&);
> +    void computePaginationInformation(RenderBox&, LayoutUnit
pageLogicalHeight, bool pageLogicalHeightChanged);

It would be nice if compute* methods would return the results instead of
mutating the object state (they could be const). This might be something to
consider in future.