[webkit-reviews] review denied: [Bug 179253] Implement ServiceWorkerContainer.getRegistration : [Attachment 325981] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has denied youenn fablet <youennf at gmail.com>'s
request for review:
Bug 179253: Implement ServiceWorkerContainer.getRegistration
https://bugs.webkit.org/show_bug.cgi?id=179253

Attachment 325981: Patch

https://bugs.webkit.org/attachment.cgi?id=325981&action=review




--- Comment #11 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 325981
  --> https://bugs.webkit.org/attachment.cgi?id=325981
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=325981&action=review

> Source/WebCore/workers/service/ServiceWorkerContainer.cpp:181
> +    ScriptExecutionContext& context = *scriptExecutionContext();

This is unsafe. scriptExecutionContext() can return null.

> Source/WebCore/workers/service/ServiceWorkerContainer.cpp:192
> +    return m_swConnection->matchRegistration(context.topOrigin(), parsedURL,
[promise = WTFMove(promise), protectedThis = makeRef(*this), this] (auto&&
result) mutable {

I think we should take a PendingActivity here.

> Source/WebCore/workers/service/ServiceWorkerContainer.cpp:201
> +	       auto& context = *scriptExecutionContext();

scriptExecutionContext() can return null.