[webkit-reviews] review granted: [Bug 176943] Storage Access API: UI process should update network process about granted access : [Attachment 325970] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted John Wilander
<wilander at apple.com>'s request for review:
Bug 176943: Storage Access API: UI process should update network process about
granted access
https://bugs.webkit.org/show_bug.cgi?id=176943

Attachment 325970: Patch

https://bugs.webkit.org/attachment.cgi?id=325970&action=review




--- Comment #7 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 325970
  --> https://bugs.webkit.org/attachment.cgi?id=325970
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=325970&action=review

> Source/WebKit/NetworkProcess/NetworkProcessCreationParameters.h:101
> +    bool storageAccessAPIEnabled;

We should consider moving these to WebsiteDataStoreParameters

> Source/WebKit/UIProcess/WebResourceLoadStatisticsStore.cpp:354
> +	   statistics.mostRecentUserInteractionTime = WallTime::now() -
Seconds::fromHours(25);

25 hours should be given a name.

> Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp:1343
> +    }, [this] (const String& resourceDomain, const String& firstPartyDomain,
bool value, WTF::Function<void(bool wasGranted)>&& callback) {

These should probably all have protectedThis = makeRef(*this).
Also, consider using CompletionHandler instead of Function to ensure it is
called only once.