[webkit-reviews] review granted: [Bug 179192] Use a single identifier type to identify Service Workers : [Attachment 325856] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Nov 3 09:21:06 PDT 2017


Brady Eidson <beidson at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 179192: Use a single identifier type to identify Service Workers
https://bugs.webkit.org/show_bug.cgi?id=179192

Attachment 325856: Patch

https://bugs.webkit.org/attachment.cgi?id=325856&action=review




--- Comment #23 from Brady Eidson <beidson at apple.com> ---
Comment on attachment 325856
  --> https://bugs.webkit.org/attachment.cgi?id=325856
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=325856&action=review

> Source/WebCore/workers/service/ServiceWorkerIdentifier.h:34
> +enum ServiceWorkerType { };

Maybe ServiceWorkerIdentifierType to reduce the possibility of collisions in
the future?


More information about the webkit-reviews mailing list