[webkit-reviews] review granted: [Bug 136107] Add USE(APPLE_INTERNAL_SDK)-guards around SPI in ResourceHandle code : [Attachment 325705] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Frédéric Wang (:fredw)
<fred.wang at free.fr>'s request for review:
Bug 136107: Add USE(APPLE_INTERNAL_SDK)-guards around SPI in ResourceHandle
code
https://bugs.webkit.org/show_bug.cgi?id=136107

Attachment 325705: Patch

https://bugs.webkit.org/attachment.cgi?id=325705&action=review




--- Comment #12 from Darin Adler <darin at apple.com> ---
Comment on attachment 325705
  --> https://bugs.webkit.org/attachment.cgi?id=325705
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=325705&action=review

> Source/WebCore/platform/network/ios/ResourceHandleIOS.mm:42
> +#if USE(APPLE_INTERNAL_SDK)
>  #import <CFNetwork/CFSocketStreamPriv.h>
>  #import <Foundation/NSURLRequestPrivate.h>
> +#else
> +#import <Foundation/NSURLRequest.h>
> + at interface NSURLRequest (Details)
> ++ (BOOL)allowsAnyHTTPSCertificateForHost:(NSString *)host;
> ++ (NSArray*)allowsSpecificHTTPSCertificateForHost:(NSString *)host;
> + at end
> +#endif
>  
> -using namespace WebCore;
> +extern "C" const CFStringRef _kCFStreamSSLTrustedLeafCertificates;

In theory this belongs in an SPI.h header; someone should move it there
eventually.

> Source/WebCore/platform/network/mac/ResourceErrorMac.mm:43
> -#if PLATFORM(IOS) && USE(CFURLCONNECTION)
> +#if PLATFORM(IOS) && USE(CFURLCONNECTION) && USE(APPLE_INTERNAL_SDK)
>  #import <CFNetwork/CFSocketStreamPriv.h>
>  #endif
>  
> +#if USE(CFURLCONNECTION)
> +extern "C" {
> +const CFStringRef _kCFStreamPropertySSLClientCertificates;
> +const CFStringRef _kCFStreamPropertySSLClientCertificateState;
> +}
> +#endif

Ditto.